feat: Error reporting at the end of the simulatiuon by arng40 · Pull Request #3929 · GEOS-DEV/GEOS

arng40 · 2025-12-23T15:52:12Z

Will be merged after : #3902

Introduce a logHistory to store all the log
Gathering logs between ranks

Located after MemoryStatsOutput :

Ex :

Types	Error	ExternalError	Warning	Exception
MeshGeneration	0	0	3	0
NumericalMethods	0	0	5	0
ImportFields	0	0	5	0

…mandinehry/create-yaml-file-and-structure

…t-test + testing GEOS_ERROR

…unit test separation for multiple EXPECT_EXIT

…upported by fmt for now)

…ASSERT and GEOS_THROW are now compatible with context parameters)

…y/create-yaml-file-and-structure

…or-context

…file-and-structure-2' into refactor/dudes/error-context

…y/create-yaml-file-and-structure-2

…-report

MelReyCG

can we see a real case sample?

MelReyCG · 2026-03-12T14:52:09Z

src/coreComponents/common/logger/LogHistory.cpp

+  }
+  else
+  {
+    it->second.m_count +=  1;


Should this be?

Suggested change

it->second.m_count += 1;

it->second.m_count += logRecord.m_value.m_count;

MelReyCG · 2026-03-18T17:25:34Z

src/coreComponents/mainInterface/GeosxState.cpp


  GEOS_THROW_IF_NE( m_state, State::UNINITIALIZED, geos::LogicError );
-
+  LogPart postProcessiveLog( "Parsing", MpiWrapper::commRank() == 0 );


What do you think of

Suggested change

LogPart postProcessiveLog( "Parsing", MpiWrapper::commRank() == 0 );

LogPart postProcessiveLog( "Input Files Processing", MpiWrapper::commRank() == 0 );

sounds better

MelReyCG · 2026-03-18T17:28:32Z

src/coreComponents/physicsSolvers/PhysicsSolverBase.cpp

+  if( MpiWrapper::commRank() == 1 )
+  {
+    GEOS_WARNING( "labla" );
+  }


Be careful, you tend to forget more and more of these in your recent works

MelReyCG · 2026-03-18T17:32:08Z

src/coreComponents/common/MpiWrapper.hpp

+      >
+    >
+  static GatherResult< CONTAINER >
+  gatherBufferRank0( CONTAINER const & localBuffer )


I'm not sure which PR should go first... One should be based on the other one because you implement this in the two PRs. Taking into account any comment / change on the other PR

MelReyCG · 2026-03-18T17:33:20Z

src/coreComponents/common/unitTests/testDataTypes.cpp

+#include "common/StdContainerWrappers.hpp"
+
+
+// // TPL includes
 #include <gtest/gtest.h>
 #include <gtest/gtest-spi.h>
+#include <memory>


you can revert

MelReyCG · 2026-03-18T17:38:01Z

src/coreComponents/common/logger/LogHistory.hpp

+    {
+      static_assert( std::is_trivially_copyable_v< T > );
+      if( ptr + sizeof(T)> end ) throw std::runtime_error( "Buffer truncated" );
+      memcpy( &data, ptr, sizeof(T) );
+      ptr += sizeof(T);
+    }


-> CPP
Here and for all other >1 function, as usual.

MelReyCG · 2026-03-18T17:41:17Z

src/coreComponents/common/logger/LogHistory.cpp

+  TableLayout tableLayout;
+  tableLayout.addColumn( "Types" );
+
+  // fill header


you can maybe add some more "part" comments for this function I think.

MelReyCG · 2026-03-18T17:42:52Z

src/coreComponents/common/logger/LogHistory.cpp

+  tableLayout.addColumn( "Types" );
+
+  // fill header
+  for( size_t msgTypeIdx = (size_t) MsgType::Error; msgTypeIdx != (size_t)MsgType::Undefined; msgTypeIdx++ )


Do as I did in my PR for the -d:

Suggested change

for( size_t msgTypeIdx = (size_t) MsgType::Error; msgTypeIdx != (size_t)MsgType::Undefined; msgTypeIdx++ )

for( size_t msgTypeIdx = 0; msgTypeIdx < (size_t)MsgType::Count; msgTypeIdx++ )

…tail' into feat/dudes/warning-report

…-report

commit b962b2c Author: arng40 <[email protected]> Date: Tue Mar 31 10:52:52 2026 +0200 :coffin: dead code & spaces commit dfe0619 Author: arng40 <[email protected]> Date: Tue Mar 31 10:51:32 2026 +0200 :art: format code commit 55aff05 Merge: ee7d7da ba863d7 Author: arng40 <[email protected]> Date: Tue Mar 31 10:51:05 2026 +0200 Merge branch 'feat/dudes/perforations-table-detail' of https://github.com/GEOS-DEV/GEOS into feat/dudes/perforations-table-detail commit ee7d7da Author: arng40 <[email protected]> Date: Tue Mar 31 10:50:50 2026 +0200 :bug: local scope for globalWellElemIndices commit ba863d7 Merge: 0d22428 510dc76 Author: Arnaud DUDES <[email protected]> Date: Tue Mar 31 10:34:16 2026 +0200 Merge branch 'develop' into feat/dudes/perforations-table-detail commit 0d22428 Merge: 17538bd 23a5694 Author: arng40 <[email protected]> Date: Mon Mar 30 18:01:56 2026 +0200 Merge branch 'feat/dudes/perforations-table-detail' of https://github.com/GEOS-DEV/GEOS into feat/dudes/perforations-table-detail commit 17538bd Author: arng40 <[email protected]> Date: Mon Mar 30 18:01:44 2026 +0200 :recycle: relocated in perfo data + renaming commit 23a5694 Merge: 1181253 acd7cc5 Author: MelReyCG <[email protected]> Date: Mon Mar 30 17:12:21 2026 +0200 Merge branch 'develop' into feat/dudes/perforations-table-detail commit 1181253 Author: arng40 <[email protected]> Date: Mon Mar 30 17:11:47 2026 +0200 :art: added boolean array for perfo availibility commit a302088 Author: MelReyCG <[email protected]> Date: Mon Mar 30 11:19:58 2026 +0200 🎨 spaces commit 935d117 Author: arng40 <[email protected]> Date: Mon Mar 30 10:12:28 2026 +0200 :art: improve testMpiTable Cond commit 7d6249d Author: arng40 <[email protected]> Date: Mon Mar 30 10:12:03 2026 +0200 :art: update perdoration sorting cond commit 81a96b2 Author: arng40 <[email protected]> Date: Mon Mar 30 10:10:21 2026 +0200 :coffin: :label: remove dead code, update types commit bdc15ec Author: arng40 <[email protected]> Date: Fri Mar 27 17:12:37 2026 +0100 :truck: move declaration outside hpp commit ecef467 Author: arng40 <[email protected]> Date: Fri Mar 27 11:15:41 2026 +0100 :green_heart: fix CI build

…arning-report

amandinehry and others added 30 commits August 21, 2025 15:07

uncomment the rmoveFile() function

e07d0b7

stack trace management

785636b

Merge remote-tracking branch 'amandinehryFork/develop' into feature/a…

dd3b844

…mandinehry/create-yaml-file-and-structure

♻️ ✅ New GEOS_ERROR macros with context included + new unit macro uni…

e0bad67

…t-test + testing GEOS_ERROR

✅ ♻️ Simplifying + testing macros (GEOS_ERROR_* and GEOS_ASSERT_*) + …

ab40edc

…unit test separation for multiple EXPECT_EXIT

📝 adding macro docs

faa84fa

✨ ✅ adding error cause in unit test

dd97f0e

♻️ reordered error & throw macro to group them

d708cac

♻️ ✅ uniformized warning macros

66ab5cb

✅ 🐛 ⚡️ bugfix when callstack is empty + disable callstack for perfs

e6135b1

♻️ ✅ uniformized throw macros

589fcfe

✅ removing _CTX macros from unit test

6fc4b30

🐛 use streamed cause string to support mpi pointers formatting (not s…

77f9fcb

…upported by fmt for now)

🐛 last mistake?

5747e7f

♻️ removing all GEOS_*_CTX macros (as GEOS_ERROR, GEOS_WARNING, GEOS_…

10eb969

…ASSERT and GEOS_THROW are now compatible with context parameters)

🎨 UNCRUSTIFY

2c5c5f5

Merge remote-tracking branch 'origin/develop' into feature/amandinehr…

d1642e6

…y/create-yaml-file-and-structure

Merge remote-tracking branch 'origin/develop' into feature/amandinehr…

b3cbb99

…y/create-yaml-file-and-structure

✨ allowing to re-throw with GEOS_THROW* macros

5781a78

📦 shema

db75e45

♻️ removing unintended BASE::

e07ab72

Merge remote-tracking branch 'origin/develop' into refactor/dudes/err…

754ed03

…or-context

xsd

83d0c0f

Merge remote-tracking branch 'origin/feature/amandinehry/create-yaml-…

d5d8615

…file-and-structure-2' into refactor/dudes/error-context

🎨 uncrustify

1913059

🐛 fix stream reset

6692dd2

⚰️ unused variable

29f6fbe

✨ removing last LVARRAY_* error logging macros

d17972f

Merge remote-tracking branch 'origin/develop' into feature/amandinehr…

759e9bb

…y/create-yaml-file-and-structure-2

✨ removing last LVARRAY_* error logging macros

1b755b5

arng40 added 5 commits March 12, 2026 16:37

doc

de4c9e7

add gatherBuffer to MPIWrapper

6a010ae

Merge remote-tracking branch 'origin/develop' into feat/dudes/warning…

db2ac84

…-report

Merge remote-tracking branch 'origin/develop' into feat/dudes/warning…

556b5e5

…-report

⏪ default allocator stdWrapper

ccdcad5

arng40 mentioned this pull request Mar 17, 2026

refactor: Move LogPart assignment #3998

Draft

arng40 added 4 commits March 17, 2026 14:31

⏪ revert logger

ca1c677

➕ add logger to scotch

16a662b

💚 doxygen & uncrustify

bf74177

💚 uncrustify

94f4209

MelReyCG requested changes Mar 18, 2026

View reviewed changes

arng40 added 3 commits March 27, 2026 09:40

🚧 serialization ( will be removed )

2940af6

📝 update doc

cdc533c

Merge remote-tracking branch 'origin/feat/dudes/perforations-table-de…

89110c9

…tail' into feat/dudes/warning-report

arng40 requested a review from tjb-ltk as a code owner March 27, 2026 08:42

🔥 remove logHistory serialization & duplication from merging

35a7d76

MelReyCG self-requested a review March 27, 2026 16:09

arng40 added 4 commits March 31, 2026 10:56

♻️ refactor llog record serialize

cf1eb6d

Merge remote-tracking branch 'origin/develop' into feat/dudes/warning…

7b85e8c

…-report

🏷️ update serial type

b6a3658

MelReyCG changed the base branch from develop to feat/dudes/perforations-table-detail March 31, 2026 12:41

MelReyCG requested review from frankfeifan, herve-gross and jhuang2601 as code owners March 31, 2026 12:41

arng40 added 5 commits March 31, 2026 12:51

Merge branch 'feat/dudes/perforations-table-detail' into feat/dudes/w…

93a1df7

…arning-report

🏷️ fix var name

b31a43a

🐛 fix warning

4939fb7

⚰️ remove log

5eea04f

Merge branch 'feat/dudes/perforations-table-detail' into feat/dudes/w…

91f1b07

…arning-report

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Error reporting at the end of the simulatiuon #3929

feat: Error reporting at the end of the simulatiuon #3929
arng40 wants to merge 346 commits intofeat/dudes/perforations-table-detailfrom
feat/dudes/warning-report

arng40 commented Dec 23, 2025 •

edited

Loading

Uh oh!

MelReyCG left a comment

Uh oh!

MelReyCG Mar 12, 2026

Uh oh!

MelReyCG Mar 18, 2026

Uh oh!

arng40 Mar 25, 2026

Uh oh!

MelReyCG Mar 18, 2026

Uh oh!

MelReyCG Mar 18, 2026

Uh oh!

arng40 Mar 27, 2026

Uh oh!

MelReyCG Mar 18, 2026

Uh oh!

MelReyCG Mar 18, 2026

Uh oh!

MelReyCG Mar 18, 2026

Uh oh!

MelReyCG Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	it->second.m_count += 1;
	it->second.m_count += logRecord.m_value.m_count;


		GEOS_THROW_IF_NE( m_state, State::UNINITIALIZED, geos::LogicError );

		LogPart postProcessiveLog( "Parsing", MpiWrapper::commRank() == 0 );

	LogPart postProcessiveLog( "Parsing", MpiWrapper::commRank() == 0 );
	LogPart postProcessiveLog( "Input Files Processing", MpiWrapper::commRank() == 0 );

	for( size_t msgTypeIdx = (size_t) MsgType::Error; msgTypeIdx != (size_t)MsgType::Undefined; msgTypeIdx++ )
	for( size_t msgTypeIdx = 0; msgTypeIdx < (size_t)MsgType::Count; msgTypeIdx++ )

Conversation

arng40 commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelReyCG left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

arng40 commented Dec 23, 2025 •

edited

Loading